lkml.org 
[lkml]   [2010]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] perf bench: port memcpy_64.S to perf bench
    From
    On Sat, Oct 30, 2010 at 06:08, Arnaldo Carvalho de Melo
    <acme@ghostprotocols.net> wrote:
    > Em Fri, Oct 29, 2010 at 09:49:11PM +0200, Peter Zijlstra escreveu:
    >> On Sat, 2010-10-30 at 01:01 +0900, Hitoshi Mitake wrote:
    >> > +++ b/arch/x86/lib/memcpy_64.S
    >> > @@ -1,10 +1,23 @@
    >> >  /* Copyright 2002 Andi Kleen */
    >> >
    >> > +/*
    >> > + * perf bench adoption by Hitoshi Mitake
    >> > + * PERF_BENCH means that this file is included from
    >> > + * the source files under tools/perf/ for benchmark programs.
    >> > + *
    >> > + * You don't have to care about PERF_BENCH when
    >> > + * you are working on the kernel.
    >> > + */
    >> > +
    >> > +#ifndef PERF_BENCH
    >>
    >> I don't like littering the actual kernel code with tools/perf/
    >> ifdeffery..
    >
    > Yeah, this kind of problem appeared in the past, we can't use things
    > that weren't specifically designed to be shared, the discussion about
    > how to properly share things between the kernel and things in tools
    > still has to happen.

    OK, it seems that I have to consider better solution.
    Could you tell me about the past problem for reference?
    Your experience must be useful for this case.

    --
    Hitoshi Mitake
    h.mitake@gmail.com
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-11-05 18:13    [W:0.021 / U:0.836 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site