[lkml]   [2010]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/1] console: add /proc/consoles
    On 11/03/2010 10:12 PM, Greg KH wrote:
    > On Wed, Nov 03, 2010 at 09:03:42PM +0100, Jiri Slaby wrote:
    >> On 11/03/2010 06:39 PM, Greg KH wrote:
    >>> On Wed, Nov 03, 2010 at 05:25:32PM +0100, Jiri Slaby wrote:
    >>>> Actually where this code should be in fs/proc/? Most of the /proc/* is
    >>>> handled elsewhere (fs/ mm/ kernel/). The rest is handled in specialized
    >>>> fs/proc/FILE.c.
    >>> What's wrong with putting it into fs/proc/proc_tty.c? That seems like
    >>> the most logical thing to me...
    >> consoles have little to do with ttys. Except ttys can be consoles.
    > And all consoles are ttys :)

    Oh, they are not. Or maybe I'm missing something?

    >> To me
    >> it seems illogical to have info about netconsole, parallel consoles or
    >> early serials somewhere in /proc/tty/. That's why I moved the info from
    >> /proc/tty/ to /proc and the code from fs/proc/proc_tty.c to
    >> kernel/printk.c where consoles are managed.
    > Ok, how about fs/proc/proc_console.c instead?

    Yes, this sounds good.

    > And no, printk.c is not the most logical place for something like this.
    > If I see a proc file, I am not going to automatically assume that
    > printk.c would have anything to do with it. As it really doesn't
    > (printk goes to the kernel log buffer, not a console).

    Actually it does all the job:
    * filling the log/ring buffer (v/printk)
    * managing consoles (un/register_console)
    * writing to consoles (call_console_drivers and friends)


     \ /
      Last update: 2010-11-04 10:59    [W:0.022 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site