Messages in this thread Patch in this message | | | From | Baruch Siach <> | Subject | [PATCH] delay.h: add __must_check to msleep_interruptible | Date | Thu, 4 Nov 2010 10:55:41 +0200 |
| |
Code calling msleep_interruptible() must be aware that sleep time might be shorter than intended as a result of a signal being caught. Code not checking the return value of msleep_interruptible() is probably buggy, unless it's doing the signal_pending() check itself, which is redundant.
Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- include/linux/delay.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/delay.h b/include/linux/delay.h index a6ecb34..1be4994 100644 --- a/include/linux/delay.h +++ b/include/linux/delay.h @@ -44,7 +44,7 @@ static inline void ndelay(unsigned long x) extern unsigned long lpj_fine; void calibrate_delay(void); void msleep(unsigned int msecs); -unsigned long msleep_interruptible(unsigned int msecs); +unsigned long __must_check msleep_interruptible(unsigned int msecs); void usleep_range(unsigned long min, unsigned long max); static inline void ssleep(unsigned int seconds) -- 1.7.2.3
| |