Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 1/1] PCI: xen-pcifront, fix PCI reference leak | Date | Thu, 4 Nov 2010 15:31:30 +0100 |
| |
Stanse found that when pdev is found and has no driver a reference is leaked in pcifront_common_process. So add pci_dev_put there. For the pdev == NULL case, pci_dev_put(NULL) is fine.
Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Jesse Barnes <jbarnes@virtuousgeek.org> --- drivers/pci/xen-pcifront.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index a87c498..f9ffc05 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -578,6 +578,7 @@ static pci_ers_result_t pcifront_common_process(int cmd, if (!pcidev || !pcidev->driver) { dev_err(&pcidev->dev, "device or driver is NULL\n"); + pci_dev_put(pcidev); return result; } pdrv = pcidev->driver; -- 1.7.3.1
| |