lkml.org 
[lkml]   [2010]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 3/3] Prevent activation of page in madvise_dontneed
    On Tue, Nov 30, 2010 at 12:23:21AM +0900, Minchan Kim wrote:
    > Now zap_pte_range alwayas activates pages which are pte_young &&
    > !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED,
    > it's unnecessary since the page wouldn't use any more.
    >
    > Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
    > Acked-by: Rik van Riel <riel@redhat.com>
    > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    > Cc: Johannes Weiner <hannes@cmpxchg.org>
    > Cc: Nick Piggin <npiggin@kernel.dk>
    > Cc: Mel Gorman <mel@csn.ul.ie>
    > Cc: Wu Fengguang <fengguang.wu@intel.com>
    >
    > Changelog since v2:
    > - remove unnecessary description
    > Changelog since v1:
    > - change word from promote to activate
    > - add activate argument to zap_pte_range and family function
    >
    > ---
    > include/linux/mm.h | 4 ++--
    > mm/madvise.c | 4 ++--
    > mm/memory.c | 38 +++++++++++++++++++++++---------------
    > mm/mmap.c | 4 ++--
    > 4 files changed, 29 insertions(+), 21 deletions(-)
    >
    > diff --git a/include/linux/mm.h b/include/linux/mm.h
    > index e097df6..6032881 100644
    > --- a/include/linux/mm.h
    > +++ b/include/linux/mm.h
    > @@ -779,11 +779,11 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
    > int zap_vma_ptes(struct vm_area_struct *vma, unsigned long address,
    > unsigned long size);
    > unsigned long zap_page_range(struct vm_area_struct *vma, unsigned long address,
    > - unsigned long size, struct zap_details *);
    > + unsigned long size, struct zap_details *, bool activate);

    I would prefer naming the parameter 'ignore_references' or something
    similar, so that it reflects the immediate effect on the zappers'
    behaviour, not what mark_page_accessed() might end up doing.

    Other than that, the patch looks good to me.

    Hannes


    \
     
     \ /
      Last update: 2010-11-30 12:39    [W:0.024 / U:0.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site