Messages in this thread | | | Date | Wed, 3 Nov 2010 04:36:03 -0700 | From | Greg KH <> | Subject | Re: [PATCH 05/10] staging: hv: Convert camel cased functions in hv.c to lower cases |
| |
On Tue, Nov 02, 2010 at 09:06:56PM +0000, Haiyang Zhang wrote: > > From: Brandon Philips [mailto:brandon@ifup.org] > > Sent: Tuesday, November 02, 2010 1:04 PM > > > -static int HvQueryHypervisorInfo(void) > > > +static int hvquery_hypervisor_info(void) > > > -static u64 HvDoHypercall(u64 control, void *input, void *output) > > > +static u64 hvdo_hypercall(u64 control, void *input, void *output) > > > > Should these be hv_do_hypercall and hv_query_hypervisor? That seems to > > be the style in the rest of the patch: > > I didn't insert underscore between every word, for example, it's not > added between two short words.
But you should. Remember, be consistent.
Care to redo these again?
thanks,
greg k-h
| |