lkml.org 
[lkml]   [2010]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] checkpatch.pl: fix CAST detection to not screw with parens handling
From
On 11/3/10, Florian Mickler <florian@mickler.org> wrote:
> On Wed, 3 Nov 2010 13:04:33 +0100
> Florian Mickler <florian@mickler.org> wrote:
>
>> Casts have to be handled after the last type that is followed by an
>> opening parenthesis is handled.
>
> That is the wrong fix. I realized now that with that patch we would
> not claim anything as a CAST anymore. Better is probably to only claim
> a CAST if av_pending is not set. Andy, would that work? It seems to be
> alright... Do you have some tests for checkpatch?
>
> Testing it with the reported line and some other random samples it
> seems to be alright.
>

Probably good enough of a test to try it on random kernel code.


\
 
 \ /
  Last update: 2010-11-03 16:29    [from the cache]
©2003-2011 Jasper Spaans