Messages in this thread | | | From | Ian Campbell <> | Date | Wed, 03 Nov 2010 12:46:34 +0000 | Subject | Re: [Xen-devel] Re: [PATCH] x86/pvclock-xen: zero last_value on resume |
| |
On Wed, 2010-10-27 at 13:59 -0700, H. Peter Anvin wrote: > I'll check it this evening when I'm at a working network again :(
Did this get applied? It seems to affect 2.6.32.x too (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602273) so can we tag it for stable as well?
Thanks, Ian.
> > "Jeremy Fitzhardinge" <jeremy@goop.org> wrote: > > > On 10/26/2010 10:48 AM, Glauber Costa wrote: > >> On Tue, 2010-10-26 at 09:59 -0700, Jeremy Fitzhardinge wrote: > >>> If the guest domain has been suspend/resumed or migrated, then the > >>> system clock backing the pvclock clocksource may revert to a smaller > >>> value (ie, can be non-monotonic across the migration/save-restore). > >>> Make sure we zero last_value in that case so that the domain > >>> continues to see clock updates. > >>> > >>> [ I don't know if kvm needs an analogous fix or not. ] > >> After migration, save/restore, etc, we issue an ioctl where we tell > >> the host the last clock value. That (in theory) guarantees > >monotonicity. > >> > >> I am not opposed to this patch in any way, however. > > > >Thanks. > > > >HPA, do you want to take this, or shall I send it on? > > > >Thanks, > > J >
-- Ian Campbell
BOFH excuse #191:
Just type 'mv * /dev/null'.
| |