Messages in this thread | | | Date | Mon, 29 Nov 2010 18:10:23 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH 1/3] KVM: X86: Introduce generic guest-mode representation |
| |
On 11/29/2010 05:38 PM, Joerg Roedel wrote: > This patch introduces a generic representation of guest-mode > fpr a vcpu. This currently only exists in the SVM code. > Having this representation generic will help making the > non-svm code aware of nesting when this is necessary. > > > > +static inline void kvm_vcpu_enter_gm(struct kvm_vcpu *vcpu) > +{ > + vcpu->arch.hflags |= HF_GUEST_MASK; > +}
I don't like the name much - the "meat" is just two letters. Please spell it out. I guess we could do is_guest_mode() like we do is_long_mode().
> + > +static inline bool kvm_vcpu_is_gm(struct kvm_vcpu *vcpu) > +{ > + return !!(vcpu->arch.hflags& HF_GUEST_MASK); > +} > +
!! unneeded with bool.
Note we need to live migrate this bit, but that's outside the scope of this patchset.
-- error compiling committee.c: too many arguments to function
| |