lkml.org 
[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] ARM: Gemini: Add support for PCI Bus
    Date
    On Monday 29 November 2010, Hans Ulli Kroll wrote:
    > @@ -1164,7 +1169,7 @@ config ISA_DMA_API
    > bool
    >
    > config PCI
    > - bool "PCI support" if ARCH_INTEGRATOR_AP || ARCH_VERSATILE_PB ||
    > ARCH_IXP4XX || ARCH_KS8695 || MACH_ARMCORE || ARCH_CNS3XXX
    > + bool "PCI support" if MIGHT_HAVE_PCI
    > help
    > Find out whether you have a PCI motherboard. PCI is the name of
    > a
    > bus system, i.e. the way the CPU talks to the other stuff inside

    This does not solve the problem that Russell mentioned: existing platforms
    select PCI unconditionally, e.g. Iop13XX, some IXP, Orion, Shark
    and more. At the very least, these would need to also select MIGHT_HAVE_PCI
    to avoid the warning.

    > index fe0c82e..f5c39a8 100644
    > --- a/arch/arm/mach-ks8695/Kconfig
    > +++ b/arch/arm/mach-ks8695/Kconfig
    > @@ -4,6 +4,7 @@ menu "Kendin/Micrel KS8695 Implementations"
    >
    > config MACH_KS8695
    > +++ b/arch/arm/mach-versatile/Kconfig
    > @@ -4,6 +4,7 @@ menu "Versatile platform type"
    > config ARCH_VERSATILE_PB
    > bool "Support Versatile/PB platform"
    > select CPU_ARM926T
    > + select HAVE_PCI
    > default y
    > help
    > Include support for the ARM(R) Versatile/PB platform.bool

    Typo: you certainly meant MIGHT_HAVE_PCI here.

    We still need to agree on what it should be doing, but otherwise this
    is what I had in mind.

    Arnd


    \
     
     \ /
      Last update: 2010-11-29 17:01    [W:0.037 / U:29.836 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site