lkml.org 
[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 0/7] hid: egalax: Rework to include Joojoo and Wetab support
On 11/29/2010 12:50 PM, Jiri Kosina wrote:

> On Mon, 29 Nov 2010, Henrik Rydberg wrote:
>
>> Hi Jiri,
>>
>> This is the second version of this patchset, extended to also support
>> the Wetab. The input core changes aside, the patches provide exactly
>> the same changes, except for a better signal-to-noise value provided
>> by Phillip.
>>
>> The first patch is already in your tree, but provided for completeness
>> (the present set is against -rc3). The second patch no longer sets up
>> the events per packet, since it is handled during slots
>> initialization. The third and fourth patch are identical, the fifth
>> has that new value, and the sixth is further simplified by using the
>> new input core interface. The seventh patch adds support for the
>> Wetab.
>>
>> The driver has been tested succesfully on all three supported device
>> ids.
>>
>> Cheers,
>> Henrik
>>
>> Henrik Rydberg (7):
>> hid: egalax: Use kzalloc
>> hid: egalax: Setup input device manually (rev2)
>> hid: egalax: Correct for device resolution report error (rev2)
>> hid: egalax: Report zero as minimum pressure (rev2)
>> hid: egalax: Add event filtering (rev3)
>> hid: egalax: Convert to MT slots (rev2)
>> hid: egalax: Add support for Wetab
>>
>> drivers/hid/hid-core.c | 1 +
>> drivers/hid/hid-egalax.c | 129 +++++++++++++++++++---------------------------
>> drivers/hid/hid-ids.h | 1 +
>> 3 files changed, 56 insertions(+), 75 deletions(-)
>
> From a quick look, it looks basically fine to me, thanks!
>
> Just a very minor nit: it'd be nice to have the Kconfig help text entry
> updated, as the eGalax driver now supports more than what is described
> there.


Something like this, perhaps?

From c6675000b59412b22f4f798de4268318e39b628c Mon Sep 17 00:00:00 2001
From: Henrik Rydberg <rydberg@euromail.se>
Date: Mon, 29 Nov 2010 14:40:11 +0100
Subject: [PATCH] hid: egalax: Document the newly supported models in Kconfig

Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
drivers/hid/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 3052e29..401acec 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -154,7 +154,8 @@ config HID_EGALAX
tristate "eGalax multi-touch panel"
depends on USB_HID
---help---
- Support for the eGalax dual-touch panel.
+ Support for the eGalax dual-touch panels, including the
+ Joojoo and Wetab tablets.

config HID_ELECOM

Thanks,
Henrik

\
 
 \ /
  Last update: 2010-11-29 14:45    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site