[lkml]   [2010]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 14/14] ptrace: remove the extra wake_up_process() from ptrace_detach()
    Today I lost the concentration at 13/14 ;)

    Will continue tomorrow. As for this patch,

    On 11/26, Tejun Heo wrote:
    > This wake_up_process() has a turbulent history. This is a remnant
    > from ancient ptrace implementation and patently wrong. Commit
    > 95a3540d (ptrace_detach: the wrong wakeup breaks the ERESTARTxxx
    > logic) removed it

    Yes. This obviously means I personally like this change. In fact,
    I never understood this wakeup, and I was glad to find the reason
    to send the patch.

    > but the change was reverted later by commit edaba2c5
    > (ptrace: revert "ptrace_detach: the wrong wakeup breaks the
    > ERESTARTxxx logic ") citing compatibility breakage and general
    > brokeness of the whole group stop / ptrace interaction.

    Yes. Honestly, I completely forgot the reason, iirc 95a3540d
    broke gdb somehow.

    Add Jan. IIRC, we had a long discussion after that, and (iirc!)
    Jan seems to agree we can kill this wakeup.


     \ /
      Last update: 2010-11-28 21:53    [W:0.020 / U:11.628 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site