lkml.org 
[lkml]   [2010]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 04/46] fs: dcache documentation cleanup
    Remove redundant (and incorrect, since dcache RCU lookup) dentry locking
    documentation and point to the canonical document.

    Signed-off-by: Nick Piggin <npiggin@kernel.dk>
    ---
    include/linux/dcache.h | 18 ++++++------------
    1 files changed, 6 insertions(+), 12 deletions(-)

    diff --git a/include/linux/dcache.h b/include/linux/dcache.h
    index 6a4aea3..fff9755 100644
    --- a/include/linux/dcache.h
    +++ b/include/linux/dcache.h
    @@ -141,22 +141,16 @@ struct dentry_operations {
    char *(*d_dname)(struct dentry *, char *, int);
    };

    -/* the dentry parameter passed to d_hash and d_compare is the parent
    +/*
    + * Locking rules for dentry_operations callbacks are to be found in
    + * Documentation/filesystems/Locking. Keep it updated!
    + *
    + * the dentry parameter passed to d_hash and d_compare is the parent
    * directory of the entries to be compared. It is used in case these
    * functions need any directory specific information for determining
    * equivalency classes. Using the dentry itself might not work, as it
    * might be a negative dentry which has no information associated with
    - * it */
    -
    -/*
    -locking rules:
    - big lock dcache_lock d_lock may block
    -d_revalidate: no no no yes
    -d_hash no no no yes
    -d_compare: no yes yes no
    -d_delete: no yes no no
    -d_release: no no no yes
    -d_iput: no no no yes
    + * it.
    */

    /* d_flags entries */
    --
    1.7.1


    \
     
     \ /
      Last update: 2010-11-27 11:29    [W:0.031 / U:92.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site