lkml.org 
[lkml]   [2010]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2]mm/oom-kill: direct hardware access processes should get bonus
    On Tue, 23 Nov 2010, KOSAKI Motohiro wrote:

    > > > > I think in cases of heuristics like this where we obviously want to give
    > > > > some bonus to CAP_SYS_ADMIN that there is consistency with other bonuses
    > > > > given elsewhere in the kernel.
    > > >
    > > > Keep comparision apple to apple. vm_enough_memory() account _virtual_ memory.
    > > > oom-killer try to free _physical_ memory. It's unrelated.
    > > >
    > >
    > > It's not unrelated, the LSM function gives an arbitrary 3% bonus to
    > > CAP_SYS_ADMIN.
    >
    > Unrelated. LSM _is_ security module. and It only account virtual memory.
    >

    I needed a small bias for CAP_SYS_ADMIN tasks so I chose 3% since it's the
    same proportion used elsewhere in the kernel and works nicely since the
    badness score is now a proportion. If you'd like to propose a different
    percentage or suggest removing the bias for root tasks altogether, feel
    free to propose a patch. Thanks!


    \
     
     \ /
      Last update: 2010-11-28 02:39    [W:2.709 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site