Messages in this thread | | | Date | Sat, 27 Nov 2010 17:44:04 -0700 | Subject | Re: toshiba_acpi.c: Full TOS1900 device support | From | Azael Avalos <> |
| |
Hi there,
Sorry for the late reply.
On Wed, Nov 24, 2010 at 12:17 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote: > Can you try this (entirely untested) patch and see if it works on your > system? It's basically your code, but with some of the conditionals > cleaned up when we already know that information.
The patch works, however, I added a couple lines in order to make it work on my laptop:
In toshiba_acpi_query_event: status = execute_acpi_method(toshiba_acpi.acpi_dev->handle, "INFO", NULL, hotkey);
Here, the handle should be the ACPI device, not the EC
In toshiba_acpi_add: /* enable hotkey event */ hci_write1(HCI_HOTKEY_EVENT, 1, &hci_result);
My model (and a couple others) the ENAB method is empty, and hotkey activation is done via HCI_HOTKEY_EVENT
Another thing that I've noticed is that "device->device_type" is always zero for me, I thought that it was supposed to be 1, due to {"TOS1900", 1}. So I changed the comparison value to 0 in order to get the hotkeys reported.
Saludos Azael
-- -- El mundo apesta y vosotros apestais tambien --
| |