Messages in this thread | | | From | Linus Torvalds <> | Date | Sat, 27 Nov 2010 07:24:37 +0900 | Subject | Re: [PATCH 17 of 66] add pmd mangling generic functions |
| |
On Fri, Nov 26, 2010 at 2:35 AM, Andrea Arcangeli <aarcange@redhat.com> wrote: > On Thu, Nov 18, 2010 at 09:32:36AM -0800, Linus Torvalds wrote: >> I dunno. Those macros are _way_ too big and heavy to be macros or >> inline functions. Why aren't pmdp_splitting_flush() etc just >> functions? > > That's because ptep_clear_flush and everything else in that file named > with ptep_* and doing expensive tlb flushes was a macro.
That may be, and you needn't necessarily clean up old use (although that might be nice as a separate thing), but I wish we didn't make what is already messy bigger and messier.
Linus
| |