lkml.org 
[lkml]   [2010]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/1] USB: cns3xxx: Add EHCI and OHCI bus glue for cns3xxx SOCs
    On Fri, Nov 26, 2010 at 06:11:31PM +0300, Anton Vorontsov wrote:
    > On Thu, Nov 25, 2010 at 03:22:06PM -0500, Alan Stern wrote:
    > [...]
    > > > > > From: Mac Lin <mkl0301@gmail.com>
    > > > > >
    > > > > > The CNS3XXX SOC has include USB EHCI and OHCI compatible controllers. This
    > > > > > patch adds the necessary glue logic to allow ehci-hcd and ohci-hcd drivers to
    > > > > > work on CNS3XXX
    > > > > >
    > > > > > The EHCI and OHCI controllers share a common clock control and reset bit,
    > > > > > therefore additional check for the timming of enabling and disabling is
    > > > > > required. The USB bit of PLL Power Down Control is also shared by OTG, 24MHz
    > > > > > UART clock, Crypto clock, PCIe reference clock, and Clock Scale Generator.
    > > > > > Therefore we only ensure it is enabled, while not disabling it.
    > > > > >
    > > > > > Signed-off-by: Mac Lin <mkl0301@gmail.com>
    > > > >
    > > > > Thanks for the patch!
    > > > >
    > > > > Cc'ing Greg.
    > > > >
    > > > > Greg, the patch doesn't touch any sensitive parts of EHCI and OHCI
    > > > > drivers, can I take it via ARM subtree? This is to not introduce
    > > > > cross-tree dependencies (the patch depends on some arch-specific
    > > > > changes).
    > > >
    > > > Please get Alan Stern to ack it as well, as he knows the proper
    > > > callbacks that you need to ensure are present.
    > >
    > > As far as the callbacks are concerned, this looks fine.
    > >
    > > Acked-by: Alan Stern <stern@rowland.harvard.edu>
    >
    > Thanks Alan!
    >
    > Greg, should I treat your 'to ack it as well' as 'Acked-by'? :-)

    Yes please:
    Acked-by: Greg Kroah-Hartman <gregkh@suse.de>



    \
     
     \ /
      Last update: 2010-11-26 18:21    [W:0.030 / U:88.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site