Messages in this thread | | | Date | Fri, 26 Nov 2010 13:18:18 +0000 | From | "Jan Beulich" <> | Subject | your patch "x86, olpc: Rework BIOS signature check" |
| |
... adds a select of OLPC_OPENFIRMWARE to the OLPC option, which contradicts OLPC_OPENFIRMWARE itself depending on !X86_64 && !X86_PAE. Are the latter dependencies not necessary anymore (the X86_64 one wasn't very meaningful anyway, since these options all sit inside a "if X86_32"), or should the select be conditional?
Also, how meaningful is having OLPC_OPENFIRMWARE on but OLPC off (i.e. can OLPC_OPENFIRMWARE perhaps go away altogether)?
Thanks, Jan
| |