lkml.org 
[lkml]   [2010]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] TTY: don't allow reopen when ldisc is changing
    On Thu, Nov 25, 2010 at 06:16:23PM +0100, Jiri Slaby wrote:
    > - if (test_bit(TTY_CLOSING, &tty->flags))
    > + if (test_bit(TTY_CLOSING, &tty->flags) ||
    > + test_bit(TTY_LDISC_CHANGING, &tty->flags))
    > return -EIO;
    >
    > if (driver->type == TTY_DRIVER_TYPE_PTY &&

    Unfortunately, users report this doesn't seem to fix things for them
    (built against 2.6.36 (plus another patch you wrote iirc.))

    https://bugzilla.redhat.com/show_bug.cgi?id=630464#c27

    I tried reverting the TTY patches between 2.6.36 and 2.6.35 and getting
    them to test that, and it seems ok:

    https://bugzilla.redhat.com/show_bug.cgi?id=630464#c30

    So I guess there must be a race here somewhere... I'll keep looking. :/

    I would imagine it's something that's probably existed since the dawn of
    time but the BKL has just papered over entirely.

    Thanks for trying!
    --Kyle


    \
     
     \ /
      Last update: 2010-11-26 10:09    [W:0.019 / U:61.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site