lkml.org 
[lkml]   [2010]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Free memory never fully used, swapping
    On Fri, Nov 26, 2010 at 09:05:56AM +0800, Shaohua Li wrote:
    > > @@ -2168,6 +2180,7 @@ static int sleeping_prematurely(pg_data_t *pgdat, int order, long remaining)
    > > static unsigned long balance_pgdat(pg_data_t *pgdat, int order)
    > > {
    > > int all_zones_ok;
    > > + int any_zone_ok;
    > > int priority;
    > > int i;
    > > unsigned long total_scanned;
    > > @@ -2201,6 +2214,7 @@ loop_again:
    > > disable_swap_token();
    > >
    > > all_zones_ok = 1;
    > > + any_zone_ok = 0;
    > >
    > > /*
    > > * Scan in the highmem->dma direction for the highest
    > > @@ -2310,10 +2324,12 @@ loop_again:
    > > * spectulatively avoid congestion waits
    > > */
    > > zone_clear_flag(zone, ZONE_CONGESTED);
    > > + if (i <= pgdat->high_zoneidx)
    > > + any_zone_ok = 1;
    > > }
    > >
    > > }
    > > - if (all_zones_ok)
    > > + if (all_zones_ok || (order && any_zone_ok))
    > > break; /* kswapd: all done */
    > > /*
    > > * OK, kswapd is getting into trouble. Take a nap, then take
    > > @@ -2336,7 +2352,7 @@ loop_again:
    > > break;
    > > }
    > > out:
    > > - if (!all_zones_ok) {
    > > + if (!(all_zones_ok || (order && any_zone_ok))) {
    > > cond_resched();
    > >
    > > try_to_freeze();
    > > @@ -2361,7 +2377,13 @@ out:
    > > goto loop_again;
    > > }
    > >
    > > - return sc.nr_reclaimed;
    > > + /*
    > > + * Return the order we were reclaiming at so sleeping_prematurely()
    > > + * makes a decision on the order we were last reclaiming at. However,
    > > + * if another caller entered the allocator slow path while kswapd
    > > + * was awake, order will remain at the higher level
    > > + */
    > > + return order;
    > > }
    > This seems always fail. because you have the protect in the kswapd side,
    > but no in the page allocation side. so every time a high order
    > allocation occurs, the protect breaks and kswapd keeps running.
    >

    I don't understand your question. sc.nr_reclaimed was being unused. The
    point of returning order was to tell kswapd that "the order you were
    reclaiming at may or may not be still valid, make your decisions on the
    order I am currently reclaiming at". The key here is if that multiple
    allocation requests come in for higher orders, kswapd will get reworken
    multiple times. Unless it gets rewoken multiple times, kswapd is willing
    to go back to sleep to avoid reclaiming an excessive number of pages.

    --
    Mel Gorman
    Part-time Phd Student Linux Technology Center
    University of Limerick IBM Dublin Software Lab


    \
     
     \ /
      Last update: 2010-11-26 09:43    [W:3.317 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site