[lkml]   [2010]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch] discourage pointless changes
    This adds a message when people use the --file option to

    NOTE: Checkpatch is a only a tool.
    Only send patches which make the code unambiguously more readable.
    Don't waste maintainer time.

    Most people use to check patches which they have written,
    but newbies use it with the --file option to find things to change.
    From the newbie perspective, we wrote so we should
    obviously be happy to fix all the errors it reports. But actually
    maitainers get cranky and that makes the newbies sad and everyone has
    a bad day.

    The message is quite blunt, but probably if people's feelings are hurt
    by a print from a script that means they are taking the script too

    Signed-off-by: Dan Carpenter <>

    diff --git a/scripts/ b/scripts/
    index e3c7fc0..36f95c1 100755
    --- a/scripts/
    +++ b/scripts/
    @@ -2937,6 +2937,13 @@ sub process {

    + if ($file && $clean == 0 && $quiet == 0) {
    + print "NOTE: Checkpatch is a only a tool.\n";
    + print " Only send patches which make the code unambiguously more readable.\n";
    + print " Don't waste maintainer time.\n";
    + print "\n";
    + }
    if ($clean == 1 && $quiet == 0) {
    print "$vname has no obvious style problems and is ready for submission.\n"

     \ /
      Last update: 2010-11-25 20:29    [W:0.020 / U:5.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site