Messages in this thread | | | Date | Thu, 25 Nov 2010 16:56:14 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH v2 2/3] ARM: cns3xxx: Add architecture definition for EHCI/OHCI controller |
| |
On Thu, Nov 25, 2010 at 09:51:23PM +0800, Lin Mac wrote: > 2010/11/25 Anton Vorontsov <cbouatmailru@gmail.com>: > > On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote: > > [...] > >> > #include <linux/module.h> > >> > #include <linux/io.h> > >> > #include <linux/delay.h> > >> > +#include <asm/atomic.h> > >> It's not necessary for mach/pm.h already included it, right? > > > > Technically, it's not necessary. But in Linux we don't rely on > > headers including other headers. Think that someday mach/pm.h > > may not include asm/atomic.h, so the build will break. > > > > Thanks, > > Get it. So should I re-submit all 3 patches, or just the last one?
Just the last one, thanks!
-- Anton Vorontsov Email: cbouatmailru@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |