lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] NET: wan/x25, fix ldisc->open retval
    Date
    We should never return positive values from ldisc->open, tty layer
    doesn't (and never did) expect that.

    If we do that, weird things like warnings in tty_ldisc_close happen.

    Not sure if dev->base_addr is used somehow now.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Alan Cox <alan@linux.intel.com>
    Cc: Andrew Hendry <andrew.hendry@gmail.com>
    Cc: linux-x25@vger.kernel.org
    ---
    drivers/net/wan/x25_asy.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
    index d81ad83..66cda25 100644
    --- a/drivers/net/wan/x25_asy.c
    +++ b/drivers/net/wan/x25_asy.c
    @@ -582,7 +582,7 @@ static int x25_asy_open_tty(struct tty_struct *tty)
    if (err)
    return err;
    /* Done. We have linked the TTY line to a channel. */
    - return sl->dev->base_addr;
    + return 0;
    }


    --
    1.7.3.1



    \
     
     \ /
      Last update: 2010-11-25 00:31    [W:0.033 / U:0.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site