Messages in this thread | | | Date | Wed, 24 Nov 2010 14:01:50 +0100 | Subject | Re: [PATCH] x86, dumpstack: Fix unused variable warning. | From | Frederic Weisbecker <> |
| |
On Wed, Nov 24, 2010 at 04:26:01PM +0600, Rakib Mullick wrote: > On Wed, Nov 24, 2010 at 3:57 PM, Jesper Juhl <jj@chaosbits.net> wrote: > > On Wed, 24 Nov 2010, Rakib Mullick wrote: > > > > > > So, now the bp variable does not exist at all if CONFIG_FRAME_POINTER is > > not defined. > > Yes - right. And its not used outside CONFIG_FRAME_POINTER. > > > That's going to make this line : > > > > show_trace(NULL, NULL, &stack, bp); > > > Not clear what are you trying to say. Would you please, clear it up a bit?
I think Jesper is confused because your patch applies on -tip (tip/master or tip/perf/core) where we have zapped the bp argument from show_trace() lately.
But in the mainline, show_trace() still has the bp argument. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |