Messages in this thread | | | Date | Wed, 24 Nov 2010 11:36:55 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500 board configuration |
| |
On Wed, Nov 24, 2010 at 09:24:14AM +0100, Bengt Jonsson wrote:
> The problem I see is that ab8500-core defines the number of > regulators which I can see no reason for. If someone wants to add or > remove a regulator they have to make a change in > include/linux/mfd/ab8500.c as well as in the regulator files.
> I will add a better description in an updated patch.
Seems reasonable, though there's now an issue with the platform getting the size of the array wrong - might be worth adding an array size for the platform to initialise to catch that.
| |