lkml.org 
[lkml]   [2010]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] kmsg_dump: adding to reboot, halt, poweroff and emergency_restart path
Date
> This patch alters mtdoops and ramoops to perform their actions only for KMSG_DUMP_PANIC,
> KMSG_DUMP_OOPS and KMSG_DUMP_KEXEC because they would like to log crashes only.
>
> Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
>
> ---
> drivers/char/ramoops.c | 5 +++++
> drivers/mtd/mtdoops.c | 5 +++++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/char/ramoops.c b/drivers/char/ramoops.c index 73dcb0e..8998b29 100644
> --- a/drivers/char/ramoops.c
> +++ b/drivers/char/ramoops.c
> @@ -69,6 +69,11 @@ static void ramoops_do_dump(struct kmsg_dumper *dumper,
> char *buf;
> struct timeval timestamp;
>
> + if (reason != KMSG_DUMP_OOPS &&
> + reason != KMSG_DUMP_PANIC &&
> + reason != KMSG_DUMP_KEXEC)
> + return;
> +
> /* Only dump oopses if dump_oops is set */
> if (reason == KMSG_DUMP_OOPS && !dump_oops)
> return;
> diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c index 1ee72f3..c948150 100644
> --- a/drivers/mtd/mtdoops.c
> +++ b/drivers/mtd/mtdoops.c
> @@ -307,6 +307,11 @@ static void mtdoops_do_dump(struct kmsg_dumper *dumper,
> unsigned long l1_cpy, l2_cpy;
> char *dst;
>
> + if (reason != KMSG_DUMP_OOPS &&
> + reason != KMSG_DUMP_PANIC &&
> + reason != KMSG_DUMP_KEXEC)
> + return;
> +
> /* Only dump oopses if dump_oops is set */
> if (reason == KMSG_DUMP_OOPS && !dump_oops)
> return;

Looks good.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>





\
 
 \ /
  Last update: 2010-11-23 09:57    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site