lkml.org 
[lkml]   [2010]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for November 23 (sep_driver)
On Tue, 23 Nov 2010 14:06:09 +1100 Stephen Rothwell wrote:

> Hi all,
>
> Changes since 20101122:


sep_driver build on x86_64 gets lots of printk format warnings.
There are 2 categories of these warnings.
(a) using %x for a size_t, when it should be %zx
(b) using %x for some _IOW() constant: no warning on i386, but
x86_64 says:

drivers/staging/sep/sep_driver.c:3415: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'

where lines 3415-3416 are:

dev_dbg(&sep->pdev->dev,
"SEP_IOCPREPAREDCB is %x\n", SEP_IOCPREPAREDCB);

Changing that to:

dev_dbg(&sep->pdev->dev,
"SEP_IOCPREPAREDCB is %lx\n", (unsigned long)SEP_IOCPREPAREDCB);

obviously fixes the printk format warning, but is there a better solution?


thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2010-11-24 01:23    [W:0.738 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site