Messages in this thread | | | Date | Tue, 23 Nov 2010 18:30:38 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500 board configuration |
| |
On Tue, Nov 23, 2010 at 07:25:52PM +0100, Bengt Jonsson wrote:
> The ab8500 regulator board configuration will be better separated > from the MFD board configuration. This patch adds a void pointer > for this purpose.
Adding something completely typesafe seems like a real loss - if you want to point to something else at least point to a particular type - eg,
struct foo;
struct pdata { int other_stuff; struct foo *foo; };
> struct regulator_init_data *regulator[AB8500_NUM_REGULATORS]; > + void *regulator_data;
It'd also help if you could articulate the problem you see with the current approach...
| |