lkml.org 
[lkml]   [2010]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 2/4] da850-evm: add UI Expander pushbuttons
    From
    Hi Kevin,

    Thank you for weighing in.

    On Tue, Nov 23, 2010 at 10:48 AM, Kevin Hilman
    <khilman@deeprootsystems.com> wrote:
    > "Nori, Sekhar" <nsekhar@ti.com> writes:
    >>> [...]
    >>> -- which is less than Ideal. How about I replace the current changes
    >>> to arch/arm/mach-davinci/Kconfig with:
    >>>
    >>> config KEYBOARD_GPIO
    >>>         default MACH_DAVINCI_DA850_EVM
    >>>         select INPUT_POLLDEV
    >>>
    >>> So 1) gpio-keys functionality is default for the da850evm and 2)
    >>> whenever gpio-keys is enabled so is INPUT_POLLDEV.
    >>
    >> This looks better than what was posted earlier, but I am not
    >> sure if platforms should influence driver configuration this
    >> way.
    >
    > Agreed.  In general, we should not have machine/platform specific
    > conditionals in generic Kconfigs.   Generally, this should be handled in
    > machine/platform specific Kconfigs.

    My understanding is that Sekhar was expressing concern over putting
    generic config conditionals into machine/platform specific Kconfigs.
    It sounds like you are OK with generic config conditionals in
    machine/platform specific Kconfigs ala recent pca953x module build
    changes [1].

    To be clear: I am proposing the following additions to
    arch/arm/mach-davinci/Kconfig: (slightly different than above).

    config KEYBOARD_GPIO
            default MACH_DAVINCI_DA850_EVM
            select INPUT_POLLDEV if MACH_DAVINCI_DA850_EVM

    I know it is always better to show the code: I will extract these
    contentious Kconfig changes into their own patch in the series when I
    post a new version.

    Best Regards,
    Ben Gardiner

    [1] http://article.gmane.org/gmane.linux.davinci/20918

    ---
    Nanometrics Inc.
    http://www.nanometrics.ca
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2010-11-23 19:01    [W:1.424 / U:0.204 seconds]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean