Messages in this thread | | | Subject | Re: [PATCH] ASoC: Do not update the cache if write to hardware failed | From | Liam Girdwood <> | Date | Tue, 23 Nov 2010 10:24:55 +0000 |
| |
On Tue, 2010-11-23 at 14:14 +0800, Axel Lin wrote: > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > sound/soc/codecs/tpa6130a2.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c > index bfef3da..2d64502 100644 > --- a/sound/soc/codecs/tpa6130a2.c > +++ b/sound/soc/codecs/tpa6130a2.c > @@ -77,8 +77,10 @@ static int tpa6130a2_i2c_write(int reg, u8 value) > > if (data->power_state) { > val = i2c_smbus_write_byte_data(tpa6130a2_client, reg, value); > - if (val < 0) > + if (val < 0) { > dev_err(&tpa6130a2_client->dev, "Write failed\n"); > + return val; > + } > } > > /* Either powered on or off, we save the context */
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk> -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
| |