Messages in this thread | | | Date | Mon, 22 Nov 2010 16:43:56 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] romfs: have romfs_fs.h pull in necessary headers |
| |
On Mon, 22 Nov 2010 19:40:16 -0500 Mike Frysinger <vapier@gentoo.org> wrote:
> On Mon, Nov 22, 2010 at 16:58, Andrew Morton wrote: > > On Sun, 21 Nov 2010 19:24:21 -0500 Mike Frysinger wrote: > >> This header uses things like __be32, so pull in linux/types.h. > >> > >> Further, it uses BLOCK_SIZE, so pull in linux/fs.h. > >> > >> --- a/include/linux/romfs_fs.h > >> +++ b/include/linux/romfs_fs.h > >> @@ -1,6 +1,9 @@ > >> __#ifndef __LINUX_ROMFS_FS_H > >> __#define __LINUX_ROMFS_FS_H > >> > >> +#include <linux/types.h> > >> +#include <linux/fs.h> > >> + > >> __/* The basic structures of the romfs filesystem */ > >> > >> __#define ROMBSIZE BLOCK_SIZE > > > > Better changelogs please. > > > > Does this fix any build error? __If so, is that build error present in > > 2.6.36 or earlier? > > headers should include the headers that define types/things that the > header itself needs
I take that to mean "no" and "no", hence the fix is not needed in 2.6.37 and is not needed in -stable.
Thanks for being so helpful.
| |