| From | Casey Leedom <> | Subject | Re: [PATCH 14/62] cxgb4vf: Use static const | Date | Mon, 22 Nov 2010 09:42:40 -0800 |
| |
| From: Joe Perches <joe@perches.com> | Date: Saturday, November 20, 2010 06:38 pm | | Using static const generally increases object text and decreases data size. | It also generally decreases overall object size. | | text data bss dec hex filename | 10179 56 2216 12451 30a3 drivers/net/cxgb4vf/t4vf_hw.o.new | 10179 56 2216 12451 30a3 drivers/net/cxgb4vf/t4vf_hw.o.old | | Signed-off-by: Joe Perches <joe@perches.com> | --- | drivers/net/cxgb4vf/t4vf_hw.c | 2 +- | 1 files changed, 1 insertions(+), 1 deletions(-) | | diff --git a/drivers/net/cxgb4vf/t4vf_hw.c b/drivers/net/cxgb4vf/t4vf_hw.c | index f7d7f97..daedf6e 100644 | --- a/drivers/net/cxgb4vf/t4vf_hw.c | +++ b/drivers/net/cxgb4vf/t4vf_hw.c | @@ -116,7 +116,7 @@ static void dump_mbox(struct adapter *adapter, const | char *tag, u32 mbox_data) int t4vf_wr_mbox_core(struct adapter *adapter, | const void *cmd, int size, void *rpl, bool sleep_ok) | { | - static int delay[] = { | + static const int delay[] = { | 1, 1, 3, 5, 10, 10, 20, 50, 100 | };
Looks okay to me. Thanks!
Casey
|