Messages in this thread |  | | | Date | Mon, 22 Nov 2010 17:58:57 +0100 | | From | Arnd Hannemann <> | | Subject | Re: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS |
| |
Am 18.11.2010 17:52, schrieb Berg, Johannes: >>>> it seems that your patch (5ada28bf76752e33dce3d807bf0dfbe6d1b943ad) >>>> causes the following compilatation error: >>>> LD .tmp_vmlinux1 >>>> drivers/built-in.o: In function `led_trigger_set': >>>> drivers/leds/led-triggers.c:116: undefined reference to >>>> `led_brightness_set' >>>> make[1]: *** [.tmp_vmlinux1] Error 1 >>>> >>>> AFAICS, led_brightness_set is defined in drivers/leds/led-class.c >> which >>>> is compiled only if CONFIG_LEDS_CLASS is configured which is not my >>>> case (after make oldconfig with all default values from 37-rc1). >>>> >>>> I am not sure what is the right solution whether >> CONFIG_LEDS_TRIGGERS >>>> should depend on CONFIG_LEDS_CLASS or the patch should be reverted. >>>> >>>> My config is attached, if somebody need it. >>> >>> Hmm, we did find that, and I made a patch to fix up the Kconfig, that >> apparently hasn't made it in? Bit confused now. >> >> Does this mean that I should enable CONFIG_LEDS_CLASS to work around >> the issue for this moment? > > I think that'd be easiest, yes.
I also ran into this today. Any updates or pointer to the patch?
Regards, Arnd
|  |