lkml.org 
[lkml]   [2010]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: Handle DT_UNKNOWN on filesystems that don't support d_type
On Sun, Nov 21, 2010 at 11:01:53AM +0100, Andreas Schwab wrote:
> Shawn Bohrer <sbohrer@rgmadvisors.com> writes:
>
> > + if (((lang_dirent.d_type == DT_DIR && \
> > + lang_dirent.d_type != DT_UNKNOWN) || \
> > + (lang_dirent.d_type == DT_UNKNOWN && \
> > + is_directory(scripts_path, &lang_dirent))) && \
>
> if ((lang_dirent.d_type == DT_DIR || \
> (lang_dirent.d_type == DT_UNKNOWN && \
> is_directory(scripts_path, &lang_dirent))) && \
>
> > + if ((script_dirent.d_type != DT_DIR && \
> > + script_dirent.d_type != DT_UNKNOWN) || \
> > + (script_dirent.d_type == DT_UNKNOWN && \
> > + !is_directory(lang_path, &script_dirent)))
>
> if (script_dirent.d_type != DT_DIR && \
> (script_dirent.d_type != DT_UNKNOWN || \
> !is_directory(lang_path, &script_dirent)))
>
> (DeMorgan: !(a && b) <-> (!a || !b); !(a || b) <-> (!a && !b))

Thanks Andreas, I'll send a follow up patch with the cleanup.

--
Shawn


\
 
 \ /
  Last update: 2010-11-21 16:57    [W:0.064 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site