lkml.org 
[lkml]   [2010]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv4 11/17] pps: simplify conditions a bit
    On Thu, Nov 18, 2010 at 07:01:04PM +0300, Alexander Gordeev wrote:
    > Bitwise conjunction is distributive so we can simplify some conditions.
    >
    > Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su>
    > ---
    > drivers/pps/kapi.c | 6 ++----
    > 1 files changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c
    > index 54261c4..2bdfbed 100644
    > --- a/drivers/pps/kapi.c
    > +++ b/drivers/pps/kapi.c
    > @@ -184,8 +184,7 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
    >
    > /* Check the event */
    > pps->current_mode = pps->params.mode;
    > - if ((event & PPS_CAPTUREASSERT) &
    > - (pps->params.mode & PPS_CAPTUREASSERT)) {
    > + if (event & pps->params.mode & PPS_CAPTUREASSERT) {
    > /* We have to add an offset? */
    > if (pps->params.mode & PPS_OFFSETASSERT)
    > pps_add_offset(&ts_real,
    > @@ -199,8 +198,7 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
    >
    > captured = ~0;
    > }
    > - if ((event & PPS_CAPTURECLEAR) &
    > - (pps->params.mode & PPS_CAPTURECLEAR)) {
    > + if (event & pps->params.mode & PPS_CAPTURECLEAR) {
    > /* We have to add an offset? */
    > if (pps->params.mode & PPS_OFFSETCLEAR)
    > pps_add_offset(&ts_real,
    > --
    > 1.7.2.3
    >

    Acked-by: Rodolfo Giometti <giometti@linux.it>

    --

    GNU/Linux Solutions e-mail: giometti@enneenne.com
    Linux Device Driver giometti@linux.it
    Embedded Systems phone: +39 349 2432127
    UNIX programming skype: rodolfo.giometti
    Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it


    \
     
     \ /
      Last update: 2010-11-20 17:17    [W:0.028 / U:29.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site