lkml.org 
[lkml]   [2010]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv4 12/17] pps: timestamp is always passed to dcd_change()
    В Sat, 20 Nov 2010 17:23:04 +0100
    Rodolfo Giometti <giometti@enneenne.com> пишет:

    > On Thu, Nov 18, 2010 at 07:01:05PM +0300, Alexander Gordeev wrote:
    > > Remove the code that gatheres timestamp in pps_tty_dcd_change() in case
    > > passed ts parameter is NULL because it never happens in the current
    > > code. Fix comments as well.
    > >
    > > Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su>
    > > ---
    > > Documentation/serial/tty.txt | 2 +-
    > > drivers/pps/clients/pps-ldisc.c | 8 --------
    > > include/linux/tty_ldisc.h | 2 +-
    > > 3 files changed, 2 insertions(+), 10 deletions(-)
    > >
    > > diff --git a/Documentation/serial/tty.txt b/Documentation/serial/tty.txt
    > > index 7c90050..540db41 100644
    > > --- a/Documentation/serial/tty.txt
    > > +++ b/Documentation/serial/tty.txt
    > > @@ -107,7 +107,7 @@ write_wakeup() - May be called at any point between open and close.
    > >
    > > dcd_change() - Report to the tty line the current DCD pin status
    > > changes and the relative timestamp. The timestamp
    > > - can be NULL.
    > > + cannot be NULL.
    >
    > Can you please explain why it cannot be null? O_o
    >
    > Who does supply the timestamp to dcd_change?

    dcd_change() is called only from one place - uart_handle_dcd_change() -
    which always obtains and passes timestamps to the former. So no need to
    check if ts is NULL and obtain ts again.

    --
    Alexander
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-11-21 01:47    [W:2.209 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site