lkml.org 
[lkml]   [2010]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH Resend] dma: imx-dma: fix imxdma_probe error path
On Tue, Nov 02, 2010 at 09:56:11AM +0800, Axel Lin wrote:
> Otherwise, the i variable will be -1 inside the latest iteration of the while loop.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

> ---
> This resend only update the commit log.
> Regards,
> Axel
>
> drivers/dma/imx-dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index f629e49..e53d438 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
> return 0;
>
> err_init:
> - while (i-- >= 0) {
> + while (--i >= 0) {
> struct imxdma_channel *imxdmac = &imxdma->channel[i];
> imx_dma_free(imxdmac->imxdma_channel);
> }
> --
> 1.7.2
>
>
>
>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


\
 
 \ /
  Last update: 2010-11-02 08:43    [W:2.181 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site