lkml.org 
[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] staging: ft1000: Remove unused char dev inerface.
On Thu, Nov 18, 2010 at 09:43:00AM +0100, Belisko Marek wrote:
> Hi Greg,
>
> On Tue, Nov 16, 2010 at 8:36 PM, Greg KH <greg@kroah.com> wrote:
> > On Sat, Nov 13, 2010 at 08:05:40PM +0100, Belisko Marek wrote:
> >> Hi Greg,
> >>
> >> On Thu, Nov 11, 2010 at 1:26 AM, Greg KH <greg@kroah.com> wrote:
> >> > On Wed, Nov 10, 2010 at 11:15:27AM +0100, Marek Belisko wrote:
> >> >> This patch remove lot of code for character device. This
> >> >> interface was used for getting network informations and
> >> >> statistics which is currently exported via /proc filesystem.
> >> >>
> >> >> Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
> >> >
> >> > This patch does not apply :(
> >> I'm trying to resend but need to wait till linux-next will sync with
> >> linus kernel.
> >> In mainline there is a patch (61241d97db02559bd83d21ffa783ab327945b925) which
> >> is not in linux-next.
> >>
> >> I try to apply patch for mainline but it failed. I'll fix and resend then.
> >> Hopefully this is correct if not forgive me ;)
> >
> > Everything should be synced up now, please resync and resend.
> I'll change my mind and from this patch series I'll resend just 1/3 patch.
> Patch 2/3 (followed by 3/3) is maybe not correct because it completely
> remove access to
> device from user space through /dev interface (used for debugging and testing).
>
> My first idea was just remove it completely because we have a device which just
> connect to network and don't need to have some debug interface.

Yes, that sounds correct. Use debugfs if you need/want a debug
interface to the driver.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-11-20 02:45    [W:0.063 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site