lkml.org 
[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[59/66] [SCSI] gdth: integer overflow in ioctl
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Dan Carpenter <error27@gmail.com>

    commit f63ae56e4e97fb12053590e41a4fa59e7daa74a4 upstream.

    gdth_ioctl_alloc() takes the size variable as an int.
    copy_from_user() takes the size variable as an unsigned long.
    gen.data_len and gen.sense_len are unsigned longs.
    On x86_64 longs are 64 bit and ints are 32 bit.

    We could pass in a very large number and the allocation would truncate
    the size to 32 bits and allocate a small buffer. Then when we do the
    copy_from_user(), it would result in a memory corruption.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/gdth.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/drivers/scsi/gdth.c
    +++ b/drivers/scsi/gdth.c
    @@ -4175,6 +4175,14 @@ static int ioc_general(void __user *arg,
    ha = gdth_find_ha(gen.ionode);
    if (!ha)
    return -EFAULT;
    +
    + if (gen.data_len > INT_MAX)
    + return -EINVAL;
    + if (gen.sense_len > INT_MAX)
    + return -EINVAL;
    + if (gen.data_len + gen.sense_len > INT_MAX)
    + return -EINVAL;
    +
    if (gen.data_len + gen.sense_len != 0) {
    if (!(buf = gdth_ioctl_alloc(ha, gen.data_len + gen.sense_len,
    FALSE, &paddr)))



    \
     
     \ /
      Last update: 2010-11-19 23:09    [W:4.098 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site