Messages in this thread | | | Date | Fri, 19 Nov 2010 20:49:31 +0100 | From | Lutz Ballaschke <> | Subject | Re: [PATCHv3 0/3] watchdog: add f71862fg support |
| |
On Sat, Oct 02, 2010 at 14:33 +0200, Wim Van Sebroeck wrote:
> On Sun, Sep 26, 2010 at 04:06:29PM +0200, Lutz Ballaschke wrote: > > > Furthermore i was thinking about modifying the WDIOC_GETTIMELEFT > ... > > and gets 6 minutes returned by ioctl. But imho it's not very accurate to > > > return a value of seconds if the wdt doesn't count in seconds. That might > > > be even more confusing. This inconsistency on the part of the hardware > > > maybe can't get satisfyingly compensated by the driver. So i'd prefer the > > > most simple solution. > ... > The return value should be the seconds before the watchdog will reboot. > So value should be seconds, not minutes and is best the safest value > (so (minutes - 1) * 60 + 1 in this case ). > Secondly: the WDIOC_GETTIMELEFT should only be a DEBUGging ioctl. > The reason I created it, is to check if certain drivers are working > or not. We should not use it in normal operations imho. > I noticed the patches for f71862fg support in f71808e driver are still missing in the recent pull request. This might be due to the ioctl implementation (PATCHv3 2/3) mentioned above which wasn't clarified. Since i missed to reply at your remarks this was my fault. Now i hope the PATCHv3 1/3 and 3/3 to get through as they already were signed-off by the author of that driver. Since the patch in question isn't essential for driver operation i suggest to drop that issue. Sorry for the inconvenience.
With kind regards,
Lutz Ballaschke
| |