lkml.org 
[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC][PATCH v2 5/7] taskstats: Improve cumulative CPU time accounting
    From
    Date
    Hello Oleg,

    On Thu, 2010-11-18 at 18:10 +0100, Oleg Nesterov wrote:
    > > 2. Because of reparent to init, there are situations where it is
    > > not clear to which tasks the CPU time of dead tasks between
    > > two snapshots has been accounted. This is a problem for example 2.
    >
    > Yes, I see.
    >
    > But I must admit, _personally_ I am not sure this problem worth the
    > trouble.

    I think you are right...

    For that function, the introduced overhead, additional code and
    especially the possible confusion with two process hierarchies is not
    worth the effort. Maybe we have a chance to solve the reparent problem
    by introducing task exit event filters (e.g. give me all exit events for
    processes that have init as parent).

    So I will send no more patches with the parallel hierarchy:
    Good news for you :-)

    But for the second problem with the forgotten CPU time, I would like
    send you a new patch set, separated as you have requested. Although I
    personally think that also there we probably have no good chances to get
    them accepted upstream, because the signal_struct size is increased and
    some cycles are added to the task exit processing.

    It would be nice, if you find some time to look at the patches,
    but no hurry!

    Michael







    \
     
     \ /
      Last update: 2010-11-19 20:49    [W:0.023 / U:0.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site