Messages in this thread | | | Date | Fri, 19 Nov 2010 11:02:42 -0800 | From | Greg KH <> | Subject | Re: [PATCH] drivers: base: core: do not put noninitialized devices |
| |
On Fri, Nov 19, 2010 at 09:41:40PM +0300, Vasiliy Kulikov wrote: > If kobject_set_name_vargs() fails then put_device() frees > device with zero kobj->state_initialized. This leads to WARN().
Have you seen this happen?
> Divide device_register() call to device_initialize() call before > kobject_set_name_vargs() and device_add() call after it. > > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> > --- > Compile tested only.
I'd prefer not to change this unless you are seeing problems with the current code.
How did kobject_set_name_vargs() fail for you?
thanks,
greg k-h
| |