Messages in this thread | | | Date | Fri, 19 Nov 2010 16:44:38 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH RESEND] perf: Remove hardcoded include paths for elfutils |
| |
Em Wed, Nov 17, 2010 at 11:11:15AM +0900, Masami Hiramatsu escreveu: > (2010/11/17 7:16), Robert Morell wrote: > > This change removes the use of hardcoded absolute > > "/usr/include/elfutils" paths from the perf build. The problem with > > hardcoded paths is that it prevents them from being overridden by > > $prefix or by -I in CFLAGS (e.g., for cross-compiling purposes). > > > > Instead, just include the "elfutils/" subdirectory as a relative path > > when files are needed from that directory. > > Looks good to me, Thanks! > > > > > Tested by building perf: > > - Cross-compiled for ARM on x86_64 > > - Built natively on x86_64 > > - Built on x86_64 with /usr/include/elfutils moved to another location > > and manually included in CFLAGS > > > > Signed-off-by: Robert Morell <rmorell@nvidia.com> > > Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks, applied,
- Arnaldo
| |