lkml.org 
[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [Ksummit-2010-discuss] checkpoint-restart: naked patch
    From
    On Fri, Nov 19, 2010 at 6:50 PM, Tejun Heo <tj@kernel.org> wrote:
    > On 11/19/2010 05:38 PM, Alexey Dobriyan wrote:
    >> On Fri, Nov 19, 2010 at 6:32 PM, Tejun Heo <tj@kernel.org> wrote:
    >>> On 11/19/2010 05:27 PM, Alexey Dobriyan wrote:
    >>>> On Fri, Nov 19, 2010 at 6:19 PM, Tejun Heo <tj@kernel.org> wrote:
    >>>>>> The paragon of absurdity is struct task_struct::did_exec .
    >>>>>
    >>>>> Yeah, then go and figure how to do that in a way which would be useful
    >>>>> for other purposes too instead of trying to shove the whole
    >>>>> checkpointer inside the kernel.  It sure would be harder but hey
    >>>>> that's the way it is.
    >>>>
    >>>> System call for one bit? This is ridiculous.
    >>>
    >>> Why not just a flag in proc entry?  It's a frigging single bit.
    >>
    >> Because /proc/*/did_exec useless to anyone but C/R (even for reading!).
    >
    > I don't think you'll need a full file.  Just shove it in status or
    > somewhere.  Your argument is completely absurd.  So, because exporting
    > single bit is so horrible to everyone else, you want to shove the
    > whole frigging checkpointer inside the kernel?
    >
    >> Because code is much simpler:
    >>
    >>     tsk->did_exec = !!tsk_img->did_exec;
    >> +
    >>     __u8 did_exec;
    >
    > Sigh, yeah, except for the horror show to create tsk_img.

    task_struct image work is common for both userspace C/R and in-kernel.
    You _have_ to define it.
    Simpler code is only first line.

    > Your "paragon of absurdity" is did_exec which is only ever used
    > to decide whether setpgid() should fail with -EACCES, seriously?
    > Here's a thought.  Ignore it for now and concentrate on more
    > relevant problems.

    You're so newjerseyly now.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-11-19 17:59    [W:0.032 / U:30.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site