Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH] mach-davinci: signedness bug | Date | Thu, 18 Nov 2010 16:28:08 -0800 |
| |
"Nori, Sekhar" <nsekhar@ti.com> writes:
> Hi Nicolas, > > On Tue, Nov 16, 2010 at 00:10:28, Nicolas Kaiser wrote: >> aemif_calc_rate() can return a negative error value, so all the >> variables that get tested for this value need to be signed. >> >> The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits >> (0xf << 26). Using a signed instead of an unsigned integer >> shouldn't make a difference here. >> >> Signed-off-by: Nicolas Kaiser <nikai@nikai.net> > > Thanks for the fix. You could use the subject: > > "davinci: signedness bug in davinci_aemif_setup_timing()" > > Other than that: > > Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks, I fixed up the subject as Sekhar suggested.
Applied, queuing for 2.6.38.
Kevin
| |