lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid mapping early during boot

* Tejun Heo <tj@kernel.org> wrote:

> Hey, Ingo.
>
> On 11/18/2010 09:30 AM, Ingo Molnar wrote:
> > This patch is still _WAY_ too large.
>
> Really? Alright, I'll split it further.

This is a very sensitive area of code that tends to blow up in nasty ways. So when
we do changes here we want them super-finegrained. If you split it up into 30
reasonable patches - no problem at all. (here up to 5 would suffice i think)

Yinghai used to have this too big patches illness too.

> > Also, these:
> >
> >> +#ifdef CONFIG_X86_32
> >> +#endif
> >
> >> +#ifdef CONFIG_X86_32
> >> +#endif
> >
> >> +#ifdef CONFIG_X86_32
> >> +#endif
> >
> >> +#ifdef CONFIG_X86_32
> >> +#endif
> >
> > Are rather ugly.
>
> Yeah, what they do is ugly. It gets less uglier after the patchset.
> I'll see if some of them can be dropped but I don't think putting them
> inside ifdef'd inline functions necessarily improves things. It often
> just makes things more difficult to follow.

Can we remove them? Or does it make any sense on the 64-bit side?

Thanks,

Ingo


\
 
 \ /
  Last update: 2010-11-18 09:45    [W:0.088 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site