Messages in this thread | | | Date | Thu, 18 Nov 2010 21:59:07 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH][resend][SCSI] Reduce number of sequential pointer derefs in scsi_error.c and reduce size as well |
| |
On Thu, 18 Nov 2010, Russell King wrote:
> On Thu, Nov 18, 2010 at 09:49:29PM +0100, Jesper Juhl wrote: > > @@ -617,10 +623,10 @@ static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd) > > > > static int __scsi_try_to_abort_cmd(struct scsi_cmnd *scmd) > > { > > - if (!scmd->device->host->hostt->eh_abort_handler) > > - return FAILED; > > - > > - return scmd->device->host->hostt->eh_abort_handler(scmd); > > + struct scsi_host_template *hostt = scmd->device->host->hostt; > > + if (!hostt->eh_abort_handler) > > + return FAILED; > > + return hostt->eh_abort_handler(scmd); > > Not that I have much to do with SCSI anymore... I spotted the above. > Is there any particular reason for using spaces to indent here rather > than our usual tabs? > No. That was me and Emacs having a slight disagreement (see the mail I just sent)...
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please.
| |