lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] x86: only call smp_processor_id in non-preempt cases
On Thu, Nov 18, 2010 at 09:14:07AM +0100, Ingo Molnar wrote:
>
> * Don Zickus <dzickus@redhat.com> wrote:
>
> > There are some paths that walk the die_chain with preemption on.
>
> What are those codepaths? At minimum it's worth documenting them.

Well the one that caused the bug was do_general_protection which walks the
die_chain with DIE_GPF.

I can document them, though it might be time consuming to audit them and
hope they don't change. I guess my bigger question is, is it expected
that anyone who calls the die_chain to have preemption disabled? If not,
then does it matter if we document it?

Cheers,
Don


\
 
 \ /
  Last update: 2010-11-18 15:25    [W:0.060 / U:2.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site