lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08 of 66] fix bad_page to show the real reason the page is bad
    On Wed, Nov 03, 2010 at 04:27:43PM +0100, Andrea Arcangeli wrote:
    > From: Andrea Arcangeli <aarcange@redhat.com>
    >
    > page_count shows the count of the head page, but the actual check is done on
    > the tail page, so show what is really being checked.
    >
    > Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
    > Acked-by: Rik van Riel <riel@redhat.com>
    > Acked-by: Mel Gorman <mel@csn.ul.ie>

    This can be sent on its own as it's not really related to THP.

    > ---
    >
    > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
    > --- a/mm/page_alloc.c
    > +++ b/mm/page_alloc.c
    > @@ -5564,7 +5564,7 @@ void dump_page(struct page *page)
    > {
    > printk(KERN_ALERT
    > "page:%p count:%d mapcount:%d mapping:%p index:%#lx\n",
    > - page, page_count(page), page_mapcount(page),
    > + page, atomic_read(&page->_count), page_mapcount(page),
    > page->mapping, page->index);
    > dump_page_flags(page->flags);
    > }
    >

    --
    Mel Gorman
    Part-time Phd Student Linux Technology Center
    University of Limerick IBM Dublin Software Lab


    \
     
     \ /
      Last update: 2010-11-18 13:43    [W:4.780 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site