lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateThu, 18 Nov 2010 12:16:36 +0100
FromAndi Kleen <>
SubjectRe: [PATCH 3/4] perf-events: Add support for supplementary event registers v3
On Thu, Nov 18, 2010 at 12:12:59PM +0100, Peter Zijlstra wrote:
> > u64 enable_mask)
> > {
> > wrmsrl(hwc->config_base + hwc->idx, hwc->config | enable_mask);
> > + if (hwc->extra_reg)
> > + wrmsrl(hwc->extra_reg, hwc->extra_config);
> > }
>
> Just wondering, shouldn't we program the extra msr _before_ we flip the
> enable bit?

Yes that makes sense.

> > + * Runs later because per cpu allocations don't work early on.
> > + */
> > +__initcall(init_intel_percore);
>
> I've got a patch moving the whole pmu init to early_initcall(), which is
> after mm_init() so it would actually work.

So do you want to make this patchkit depend on that patch?
Or just integrate it and then change later?

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2010-11-18 12:19    [from the cache]
©2003-2010